From: Daniel Boles Date: Tue, 19 Dec 2017 18:07:02 +0000 (+0000) Subject: Range: Fix inverted vert scrolling on horiz Ranges X-Git-Tag: archive/raspbian/3.24.39-1+rpi1~1^2~65^2~38^2~111 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success/%22http:/www.example.com/cgi/success?a=commitdiff_plain;h=4d18a346c14898db2f0e014eaeaa54932b670ea6;p=gtk%2B3.0.git Range: Fix inverted vert scrolling on horiz Ranges Users expect, & previous patches have tried to assure, that scrolling up over a horizontal Range will cause the value to increase & vice-versa. But the path using directions was still negating the delta & decreasing the value on scrolling up. This could be seen on Win32 or X without XI2. So, only negate the delta when scrolling down (or left), not up, so that scrolling up (or right) will make the value increase for any event type. https://bugzilla.gnome.org/show_bug.cgi?id=737175#c5 --- diff --git a/gtk/gtkrange.c b/gtk/gtkrange.c index 78736871cc..16e78f16d3 100644 --- a/gtk/gtkrange.c +++ b/gtk/gtkrange.c @@ -3059,7 +3059,7 @@ _gtk_range_get_wheel_delta (GtkRange *range, } else if (gdk_event_get_scroll_direction ((GdkEvent *) event, &direction)) { - if (direction == GDK_SCROLL_UP || + if (direction == GDK_SCROLL_DOWN || direction == GDK_SCROLL_LEFT) delta = - scroll_unit; else